launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/bug-826692-take2 into lp:launchpad has been updated.

Description changed to:

= Bug 826692: resubmit =

This has mostly been reviewed in https://code.launchpad.net/~danilo/launchpad/bug-826692/+merge/71836

However, that didn't work for private branches.  The only change (other than a few more lint fixes) is the one below:

== Proposed fix ==

http://paste.ubuntu.com/675046/

== Tests ==

bin/test -cvvt ActiveReviewsWithPrivateBranches -t TestLandingCandidates

(TestLandingCandidates was introduced when the landing was reverted)

== Demo and Q/A ==

Go to a Landscape branch lp:landscape and look at merge proposals page for it (note, go to the branch, not the project page).  The number of proposals there should match the number listed on the branch page.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/model/branchcollection.py
  lib/lp/code/interfaces/branch.py
  lib/lp/code/interfaces/branchcollection.py
  lib/lp/code/model/branch.py
  lib/lp/code/browser/branchmergeproposallisting.py
  lib/lp/code/browser/tests/test_branchmergeproposallisting.py

For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-826692-take2/+merge/72996
-- 
https://code.launchpad.net/~danilo/launchpad/bug-826692-take2/+merge/72996
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-826692-take2 into lp:launchpad.