launchpad-reviewers team mailing list archive

[Nigel Babu <nigelbabu@xxxxxxxxx>]

Nigel Babu has proposed merging lp:~nigelbabu/launchpad/833743-revno-fail into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #833743 in Launchpad itself: "test_versioninfo fails when system has bzr 2.4"
  https://bugs.launchpad.net/launchpad/+bug/833743

For more details, see:
https://code.launchpad.net/~nigelbabu/launchpad/833743-revno-fail/+merge/73008

Update version info test to be compatible with bzr 2.4
-- 
https://code.launchpad.net/~nigelbabu/launchpad/833743-revno-fail/+merge/73008
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~nigelbabu/launchpad/833743-revno-fail into lp:launchpad.

=== modified file 'lib/lp/app/tests/test_versioninfo.py'
--- lib/lp/app/tests/test_versioninfo.py	2010-12-13 18:04:24 +0000
+++ lib/lp/app/tests/test_versioninfo.py	2011-08-26 09:28:38 +0000
@@ -21,4 +21,4 @@
                 "print revno"]
         process = subprocess.Popen(args, cwd='/tmp', stdout=subprocess.PIPE)
         (output, errors) = process.communicate(None)
-        self.assertEquals(revno, int(output))
+        self.assertEquals(int(revno), int(output))