← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~mwhudson/launchpad/feature-flag-xmlrpc into lp:launchpad

 

* if we passed a dict of values from the client, would that make it
easier to consider other factors later (like the client ip, bzr
version, front end server, etc)?  bearing in mind that different
machines that talk to the xmlrpc server may have different subsets of
these, hardcoding them as parameters may be inflexible.  (maybe xmlrpc
can't do a dict but you can do a list of pairs of strings.)

* maybe FixedScope could be somewhere more general (why not have it
available in production, for that matter.)

* there are developer docs in the tree that ought to be updated.

this looks really useful, thanks.

-- 
https://code.launchpad.net/~mwhudson/launchpad/feature-flag-xmlrpc/+merge/75673
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mwhudson/launchpad/feature-flag-xmlrpc into lp:launchpad.


Follow ups

References