launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

I kindof had it in my head that we could inject more info about the
context in the method - e.g. rather than saying
scopes=('pageid:1234',) we could use the standard scope lookup code
and just inject the current user, current server etc into that.

This is particularly relevant if you consider the scope 'random:0.5'
(true 50% of the time).

I think this needs a (small) bit of rework to be able to delegate to
the stock scope facilities TBH.

Even if the first cut doesn't *need* that, I think the contract should
be one that is amenable to that. IOW, rather than passing in the live
scopes, pass in the context used to derive live scopes, and get rid of
your custom scope lookup code. (It duplicates the team scope handling
anyway, and that also is a must-fix).

-Rob

-- 
https://code.launchpad.net/~mwhudson/launchpad/feature-flag-xmlrpc/+merge/75673
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mwhudson/launchpad/feature-flag-xmlrpc into lp:launchpad.