launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Ah, this is much better.

+ scopes = [
177	DefaultScope(),
181	+ PageScope(request._orig_env.get('launchpad.pageid', '')),
182	+ ServerScope(),
183	+ ]

I would like there to be one-place to add scopes like RandomScope etc - so perhaps:

default_scopes = [DefaultScope()]

and then in the relevant places

scopes = list(default_scopes)
scopes.extend([PageScope(...), ServerScope(),...])

etc.

What do you think?

-- 
https://code.launchpad.net/~mwhudson/launchpad/feature-flag-xmlrpc/+merge/75673
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mwhudson/launchpad/feature-flag-xmlrpc into lp:launchpad.