launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/private-loggerhead-notifications into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/private-loggerhead-notifications/+merge/80475

Summary
=======
In order to display the privacy banner on loggerhead, this branch introduces a mechanism to pass in a "private" var into the initialization of the BranchWSGIApp.

Preimp
======
Spoke with Curtis Hovey

Implementation
==============
Launchpad's loggerhead instance is launched via the app.py file in lib/launchpad_loggerhead. As part of this file's setup, an anon query is made to the api URI for the branch in question. Error return codes of 400 and 403 indicate the branch must be private. This information is then passed into loggerhead. This branch is intended to go with lp:~jcsackett/loggerhead/add-privacy-ribbon.

QA
==
This branch alone is largely un-qa-able.

Lint
====
This branch is lint free.
-- 
https://code.launchpad.net/~jcsackett/launchpad/private-loggerhead-notifications/+merge/80475
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/private-loggerhead-notifications into lp:launchpad.