← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~abentley/launchpad/navigate-batches into lp:launchpad

 

That's not a review, but I simply wanted to know why we want to handle the 'last page' as part of the cache. The fact that you can go the "last page" of our batch navigator has often been described as a misfeature, as usually there is not a lot of value on the last page! Also retrieving the last batch of query (using offset and limit) performs usually very bad. Not sure if that's the case in the bugs context, but I'd suggest studying the use-cases here to see if we really need to support a 'Last' button in the AJAX case. 
-- 
https://code.launchpad.net/~abentley/launchpad/navigate-batches/+merge/80502
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/navigate-batches into lp:launchpad.


References