launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/beta-banner-design into lp:launchpad with lp:~huwshimi/launchpad/update-cssutils-version as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #898939 in Launchpad itself: "beta banner is missing design"
  https://bugs.launchpad.net/launchpad/+bug/898939

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/beta-banner-design/+merge/84198

A few design styles were missing from the beta banner, I've updated the design to match my original design. A screenshot of the changes is here: https://bugs.launchpad.net/launchpad/+bug/898939/+attachment/2615500/+files/beta_banner_improvements.png
-- 
https://code.launchpad.net/~huwshimi/launchpad/beta-banner-design/+merge/84198
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/beta-banner-design into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/css/components/beta_banner.css'
--- lib/canonical/launchpad/icing/css/components/beta_banner.css	2011-11-22 21:38:36 +0000
+++ lib/canonical/launchpad/icing/css/components/beta_banner.css	2011-12-02 03:57:36 +0000
@@ -7,12 +7,14 @@
     top: 0;
     left: 0;
     right: 0;
-    padding: 8px 20px;
+    padding: 7px 20px;
     /* Define colour for browsers that don't support transparency */
     background-color: #606060;
     /* Set transparent background for browsers that support it */
     background-color: rgba(64, 64, 64, 0.9);
+    box-shadow: 0 0 5px #333;
     color: #fff;
+    text-shadow: 0 -1px 0 rgba(0, 0, 0, 0.5);
     font-size: 14px;
     line-height: 21px;
     }
@@ -20,11 +22,20 @@
     color: #4884ef;
 }
 .beta-warning {
-    padding: 4px;
+    padding: 3px 6px 4px 6px;
     margin-right: 12px;
     background-color: #be0000;
     font-weight: bold;
+    font-size: 12px;
+    text-shadow: 0 -1px 0 rgba(0, 0, 0, 0.25);
     border-radius: 4px;
+    border-top: 1px solid #e20000;
+    background-color: #c10000;
+    background: linear-gradient(bottom, rgb(158,0,0) 0%, rgb(193,0,0) 70%);
+    background: -o-linear-gradient(bottom, rgb(158,0,0) 0%, rgb(193,0,0) 70%);
+    background: -moz-linear-gradient(bottom, rgb(158,0,0) 0%, rgb(193,0,0) 70%);
+    background: -webkit-linear-gradient(bottom, rgb(158,0,0) 0%, rgb(193,0,0) 70%);
+    background: -ms-linear-gradient(bottom, rgb(158,0,0) 0%, rgb(193,0,0) 70%);
     }
 .beta-feature {
     font-weight: bold;