launchpad-reviewers team mailing list archive

[Loïc Minier <lool@xxxxxxxx>]

Loïc Minier has proposed merging lp:~lool/launchpad-buildd/log-kernel-version into lp:launchpad-buildd.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lool/launchpad-buildd/log-kernel-version/+merge/84247

This will log uname -r output to get the kernel version in build logs, just after the version of toolchain packages; this might be useful to track down issues with e.g. hardy vs. lucid buildds, or to decide list of packages to rebuild.

NB: I only made sure it's valid Perl, I don't have an environment to run launchpad-buildd.
-- 
https://code.launchpad.net/~lool/launchpad-buildd/log-kernel-version/+merge/84247
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lool/launchpad-buildd/log-kernel-version into lp:launchpad-buildd.

=== modified file 'sbuild'
--- sbuild	2011-11-29 06:09:01 +0000
+++ sbuild	2011-12-02 11:41:21 +0000
@@ -2175,6 +2175,9 @@
 		}
 		print PLOG "\n";
 	}
+	if (!$fail) {
+		print PLOG "Kernel version: " . `uname -r`;
+	}
 
 	return $fail;
 }