launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~jtv/launchpad/bug-849683-cloner into lp:launchpad

To: mp+84222@xxxxxxxxxxxxxxxxxx
From: Abel Deuring <abel.deuring@xxxxxxxxxxxxx>
Date: Fri, 02 Dec 2011 13:31:58 -0000
In-reply-to: <20111202074047.23622.47644.launchpad@ackee.canonical.com>
Reply-to: mp+84222@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

(11:24:01) adeuring: jtv: the changes look good, and thanks a lot for the nice reformatting. just one question: what about a test?
(11:24:47) jtv: adeuring: good point — we know that the column is initialized, but it'd be nice to check it for correctness.  Let me just see what the existing tests do.
-- 
https://code.launchpad.net/~jtv/launchpad/bug-849683-cloner/+merge/84222
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-849683-cloner into lp:launchpad.

References

[Merge] lp:~jtv/launchpad/bug-849683-cloner into lp:launchpad
From: Jeroen T. Vermeulen, 2011-12-02