launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

+    def outputPath(self, flavour, series_name, arch, base):
+        return os.path.join(
+            self.config.germinateroot,
+            '%s_%s_%s_%s' % (base, flavour, series_name, arch))

Our dromedary-cased method names normally start with a verb.  Read that way, “outputPath” would suggest that the method prints a path.

So consider prefixing this method's name with a verb.  The unimaginative catch-all verb is “get”; personally I prefer “compose” for this kind of thing.
-- 
https://code.launchpad.net/~cjwatson/launchpad/refactor-cron-germinate/+merge/84624
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad.