launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/soyuz-test-mail-ordering into lp:launchpad has been updated.

Description changed to:

= Summary =

Fix a couple of test failures on i386 due to relying on the iteration order of sets.

== Proposed fix ==

Introduce an lp.testing.mail_helpers.sort_addresses helper and use that in the doctests.

print_emails does some similar sorting already, but I wanted something to just sort the addresses and nothing else, and it couldn't be easily extracted.  At three lines, it wasn't worth agonising over.  I couldn't find any existing helper that did quite the right thing; feel free to correct me if I missed something.

== Pre-implementation notes =

Curtis pointed out in the bug that it was more usual to do the sorting in the tests rather than in the tested code.  I'm more comfortable with that anyway.

== Implementation details ==

None.

== Tests ==

bin/test -vvct 'soyuz-set-of-uploads|xx-queue-pages'

== Demo and Q/A ==

None.

== lint ==

Loads of pre-existing lint in lib/lp/soyuz/stories/soyuz/xx-queue-pages.txt.  I fixed quite a lot of it, but there are still quite a few "want exceeds 78 characters" entries which correspond to wide queue tables, that I didn't want to get into fixing.  (This fix will make the diff as a whole hard to understand, I'm afraid; try just the first revision in this branch.)

I fixed a bit of pre-existing lint in lib/lp/testing/mail_helpers.py too.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/soyuz-test-mail-ordering/+merge/85979
-- 
https://code.launchpad.net/~cjwatson/launchpad/soyuz-test-mail-ordering/+merge/85979
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/soyuz-test-mail-ordering into lp:launchpad.