launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/gear-icon-visibility-894729 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #894729 in Launchpad itself: "Gear icon maybe too subtle"
  https://bugs.launchpad.net/launchpad/+bug/894729

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/gear-icon-visibility-894729/+merge/85986

There were reports that the gear icon was too subtle. I've moved the icon to the left so that it will be more frequently in the users field of vision and have also made the icon a lot darker.

While outside of this bug I also added a tooltip to the icon to help people understand what the icon is there for.

Here's a screenshot of the changes: https://launchpadlibrarian.net/87611663/configure_icon.png
-- 
https://code.launchpad.net/~huwshimi/launchpad/gear-icon-visibility-894729/+merge/85986
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/gear-icon-visibility-894729 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/images/config.png'
Binary files lib/canonical/launchpad/images/config.png	2011-11-03 20:22:52 +0000 and lib/canonical/launchpad/images/config.png	2011-12-16 03:50:31 +0000 differ
=== modified file 'lib/lp/app/javascript/configutils.js'
--- lib/lp/app/javascript/configutils.js	2011-11-08 14:57:08 +0000
+++ lib/lp/app/javascript/configutils.js	2011-12-16 03:50:31 +0000
@@ -64,6 +64,7 @@
         renderUI: function() {
             var anchor = Y.Node.create(
                 '<a></a>').addClass('sprite').addClass('config');
+            anchor.set('title', 'Customise visible bug information');
             this.set('anchor', anchor);
             var content = this.get(CONTENT_BOX);
             content.append(anchor);

=== modified file 'lib/lp/app/javascript/ordering/assets/ordering-core.css'
--- lib/lp/app/javascript/ordering/assets/ordering-core.css	2011-12-05 07:00:37 +0000
+++ lib/lp/app/javascript/ordering/assets/ordering-core.css	2011-12-16 03:50:31 +0000
@@ -32,9 +32,10 @@
     }
 
 .yui3-orderbybar .config-widget {
-    float: right;
-    border-left: 1px solid #EEE;
-    margin: 3px;
+    float: left;
+    border-right: 1px solid #EEE;
+    margin: 4px 3px;
+    padding-right: 4px;
     min-width: 20px;
     min-height: 20px;
     }

=== modified file 'lib/lp/app/javascript/ordering/ordering.js'
--- lib/lp/app/javascript/ordering/ordering.js	2011-12-08 13:23:00 +0000
+++ lib/lp/app/javascript/ordering/ordering.js	2011-12-16 03:50:31 +0000
@@ -356,7 +356,7 @@
             if (this.get('config_slot')) {
                 var config_div = Y.Node.create('<div></div>').addClass(
                     'config-widget');
-                div.appendChild(config_div);
+                div.prepend(config_div);
                 this.set('config_node', config_div);
             }
             this.get('srcNode').appendChild(div);