launchpad-reviewers team mailing list archive

[Iain Lane <iain@xxxxxxxxxxxxxxxxxxx>]

The proposal to merge lp:~laney/launchpad/add-sponsor-field-to-spph into lp:launchpad has been updated.

Description changed to:

If copyPackage is sponsored, save sponsor in SPPH.

== Test ==

bin/test -cvv test_copypackage -t test_sponsored_copy_sponsor_field -t test_unsponsored_copy_does_not_set_sponsor

 Running:
  lp.soyuz.scripts.tests.test_copypackage.TestDoDirectCopy.test_sponsored_copy_sponsor_field
  lp.soyuz.scripts.tests.test_copypackage.TestDoDirectCopy.test_unsponsored_copy_does_not_set_sponsor
 Ran 2 tests with 0 failures and 0 errors in 6.150 seconds.

== Demo and QA ==

Find a package which is newer in Debian than Ubuntu and copy it into Ubuntu using copyPackage and setting the sponsored field to some user. Ensure that the sponsor field of the resulting SPPH is set to your user.

== lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/soyuz/interfaces/publishing.py
  lib/lp/soyuz/model/publishing.py
  lib/lp/soyuz/scripts/packagecopier.py
  lib/lp/soyuz/scripts/tests/test_copypackage.py

./lib/lp/soyuz/scripts/tests/test_copypackage.py
    1456: Line exceeds 78 characters.
    1456: E501 line too long (82 characters)
make: *** [lint] Error 2

Preexisting and AFAICS not fixable as it is matching a string from an email.

For more details, see:
https://code.launchpad.net/~laney/launchpad/add-sponsor-field-to-spph/+merge/87930
-- 
https://code.launchpad.net/~laney/launchpad/add-sponsor-field-to-spph/+merge/87930
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~laney/launchpad/add-sponsor-field-to-spph into lp:launchpad.