launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~jcsackett/launchpad/bad-headers-are-bad into lp:launchpad

To: mp+91726@xxxxxxxxxxxxxxxxxx
From: "j.c.sackett" <jcsackett@xxxxxxxxxxxxx>
Date: Mon, 06 Feb 2012 21:57:19 -0000
Reply-to: mp+91726@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

j.c.sackett has proposed merging lp:~jcsackett/launchpad/bad-headers-are-bad into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/bad-headers-are-bad/+merge/91726

Summary
=======
Distribution index and ProjectGroup index pages both have redundant secondary
headings with <h1> markup. This branch removes them.

Preimplementation
=================
Spoke with Curtis Hovey

Implementation
==============
Although the bug and preimp talks indicated implementation of the wrong base
view as the probable issue, the actual cause is much more prosaic--both had a
"header" section implemented within the body of their associated template,
displaying the context title a second time. Deleting that tal block removes
the redundant heading.

Tests
=====
None

QA
==
Confirm that the ProjectGroup and Distribution index pages do not show a
second, redundant heading after the menu links.

Lint
====
This branch is lint free.
-- 
https://code.launchpad.net/~jcsackett/launchpad/bad-headers-are-bad/+merge/91726
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/bad-headers-are-bad into lp:launchpad.

=== modified file 'lib/lp/registry/templates/distribution-index.pt'
--- lib/lp/registry/templates/distribution-index.pt	2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/distribution-index.pt	2012-02-06 21:56:19 +0000
@@ -23,10 +23,6 @@
   </head>
 
   <body>
-    <tal:heading metal:fill-slot="heading">
-      <h1 itemprop="name" tal:content="context/title">project title</h1>
-    </tal:heading>
-
     <tal:registering metal:fill-slot="registering">
         Registered by
         <a tal:replace="structure context/registrant/fmt:link" />

=== modified file 'lib/lp/registry/templates/project-index.pt'
--- lib/lp/registry/templates/project-index.pt	2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/project-index.pt	2012-02-06 21:56:19 +0000
@@ -31,10 +31,6 @@
       <tal:registrant replace="structure context/registrant/fmt:link" />
     </tal:registering>
 
-    <tal:heading metal:fill-slot="heading">
-      <h1 tal:content="context/title">Mozilla</h1>
-    </tal:heading>
-
     <tal:main metal:fill-slot="main">
 
     <div class="top-portlet">