← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wallyworld/launchpad/remove-sharing-audit-link into lp:launchpad

 

Ian Booth has proposed merging lp:~wallyworld/launchpad/remove-sharing-audit-link into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #978238 in Launchpad itself: "The audit link on the sharing page does nothing"
  https://bugs.launchpad.net/launchpad/+bug/978238

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/remove-sharing-audit-link/+merge/101477

Small change to remove the audit link on the +sharing page - we are doing auditing later. 
I have a branch already that was reverted until we revisit auditing which will add the link back.
-- 
https://code.launchpad.net/~wallyworld/launchpad/remove-sharing-audit-link/+merge/101477
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/remove-sharing-audit-link into lp:launchpad.
=== modified file 'lib/lp/registry/templates/pillar-sharing.pt'
--- lib/lp/registry/templates/pillar-sharing.pt	2012-03-31 11:32:15 +0000
+++ lib/lp/registry/templates/pillar-sharing.pt	2012-04-11 02:36:18 +0000
@@ -31,7 +31,6 @@
     <ul class="horizontal">
       <li><a id='add-sharee-link' class='sprite add js-action' href="#">Share
         with someone</a></li>
-      <li><a id="audit-link" class="sprite info" href='#'>Audit sharing</a></li>
     </ul>
 
     <div tal:define="batch_navigator view/sharees">


Follow ups