launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/improve-shared-items-text-978513 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #978513 in Launchpad itself: "Improve shared items text on +sharing page"
  https://bugs.launchpad.net/launchpad/+bug/978513

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/improve-shared-items-text-978513/+merge/101479

== Implementation ==

See bug report for rationale. Small change to improve the text displayed when it is not relevant to allow the user to navigate to subscribed bugs and branches.

== Tests ==

Update shareetable test.

== Lint ==

Linting changed files:
  lib/lp/registry/javascript/sharing/shareetable.js
  lib/lp/registry/javascript/sharing/tests/test_shareetable.js
  lib/lp/registry/templates/pillar-sharing-details.pt

-- 
https://code.launchpad.net/~wallyworld/launchpad/improve-shared-items-text-978513/+merge/101479
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/improve-shared-items-text-978513 into lp:launchpad.

=== modified file 'lib/lp/registry/javascript/sharing/shareetable.js'
--- lib/lp/registry/javascript/sharing/shareetable.js	2012-04-04 13:10:15 +0000
+++ lib/lp/registry/javascript/sharing/shareetable.js	2012-04-11 03:00:29 +0000
@@ -180,7 +180,8 @@
             '<a href="+sharing/{{name}}">View shared items.</a>',
             '{{/shared_items_exist}}',
             '{{^shared_items_exist}}',
-            '<span class="formHelp">No items shared.</span>',
+            '<span class="formHelp">No items shared through subscriptions.',
+            '</span>',
             '{{/shared_items_exist}}',
             '</td>',
             '</tr>'].join(' ');

=== modified file 'lib/lp/registry/javascript/sharing/tests/test_shareetable.js'
--- lib/lp/registry/javascript/sharing/tests/test_shareetable.js	2012-04-06 17:28:25 +0000
+++ lib/lp/registry/javascript/sharing/tests/test_shareetable.js	2012-04-11 03:00:29 +0000
@@ -159,7 +159,7 @@
                         'a[href=+sharing/' + sharee.name + ']'));
             } else {
                 Y.Assert.areEqual(
-                    'No items shared.',
+                    'No items shared through subscriptions.',
                     Y.Lang.trim(shared_items_cell.get('text')));
             }
         },

=== modified file 'lib/lp/registry/templates/pillar-sharing-details.pt'
--- lib/lp/registry/templates/pillar-sharing-details.pt	2012-04-06 17:28:25 +0000
+++ lib/lp/registry/templates/pillar-sharing-details.pt	2012-04-11 03:00:29 +0000
@@ -46,7 +46,7 @@
       <thead>
         <tr>
           <th colspan="4" width="">
-            <a href="#" class="sortheader">Bug Report or Branch</a>
+            <a href="#" class="sortheader">Subscribed Bug Report or Branch</a>
           </th>
         </tr>
       </thead>