launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/privacy-portlet-text into lp:launchpad.

Requested reviews:
  Dan Harrop-Griffiths (danhg): text

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/privacy-portlet-text/+merge/103645

The new text in the bug privacy portlet scans a little wrong when the information type is Embargoed Security or Unembargoed Security for starters. Change it to wording that sounds better.
-- 
https://code.launchpad.net/~stevenk/launchpad/privacy-portlet-text/+merge/103645
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/tests/test_information_type_choice.html'
--- lib/lp/bugs/javascript/tests/test_information_type_choice.html	2012-04-24 07:44:29 +0000
+++ lib/lp/bugs/javascript/tests/test_information_type_choice.html	2012-04-26 09:57:24 +0000
@@ -68,7 +68,7 @@
         </ul>
         <div id="privacy">
             <div id="privacy-text">
-                This report contains information that is <strong id="information-type">Public</strong><a class="sprite edit" id="privacy-link" href="#">edit</a>
+                This report contains <strong id="information-type">Public</strong> information <a class="sprite edit" id="privacy-link" href="#">edit</a>
             </div>
         </div>
         <div id="current_user_subscription">

=== modified file 'lib/lp/bugs/templates/bug-portlet-privacy.pt'
--- lib/lp/bugs/templates/bug-portlet-privacy.pt	2012-04-18 06:14:54 +0000
+++ lib/lp/bugs/templates/bug-portlet-privacy.pt	2012-04-26 09:57:24 +0000
@@ -10,7 +10,7 @@
 >
   <div id="privacy-text">
     <tal:information_type tal:condition="view/show_information_type_in_ui">
-      This report contains information that is <strong id="information-type" tal:content="view/information_type"></strong>&nbsp;<a class="sprite edit" id="privacy-link" tal:attributes="href link/path" tal:condition="link/enabled"></a>
+      This report contains <strong id="information-type" tal:content="view/information_type"></strong> information&nbsp;<a class="sprite edit" id="privacy-link" tal:attributes="href link/path" tal:condition="link/enabled"></a>
     </tal:information_type>
     <tal:privacy tal:condition="not:view/show_information_type_in_ui">
       <div tal:condition="not:context/private" id="privacy-text">