← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad

 

Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-old-fakelibrarian/+merge/103651

All former users of this deprecated module have been moved over to lp.services.librarianserver.testing.fake, so it's safe to remove it now.
-- 
https://code.launchpad.net/~cjwatson/launchpad/remove-old-fakelibrarian/+merge/103651
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/remove-old-fakelibrarian into lp:launchpad.
=== removed file 'lib/lp/testing/fakelibrarian.py'
--- lib/lp/testing/fakelibrarian.py	2011-12-30 01:48:17 +0000
+++ lib/lp/testing/fakelibrarian.py	1970-01-01 00:00:00 +0000
@@ -1,18 +0,0 @@
-# Copyright 2010 Canonical Ltd.  This software is licensed under the
-# GNU Affero General Public License version 3 (see the file LICENSE).
-
-"""See lp.services.librarianserver.testing.fake."""
-
-import warnings
-
-from lp.services.librarianserver.testing.fake import (
-    FakeLibrarian as _FakeLibrarian,
-    )
-
-
-def FakeLibrarian(*args, **kwargs):
-    """Forward to the new home with a deprecation warning."""
-    warnings.warn("Stale import: please import FakeLibrarian from "
-        "lp.services.librarianserver.testing.fake instead.", DeprecationWarning,
-        stacklevel=2)
-    return _FakeLibrarian(*args, **kwargs)


Follow ups