launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

> I'm guessing the rationale for make_question_job is that there's no need for
> it outside that file? As such I'm fine with not adding it to the factory.

Right.  It's not a generic function to create a QuestionJob, it's specifically for (some of) these tests.

> Rick's point about named tuple is a good one, but I think it's very optional.
> I agree with his request for the additional check, though.

Okay.
-- 
https://code.launchpad.net/~abentley/launchpad/celery-everywhere-9/+merge/103723
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.