launchpad-reviewers team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

The proposal to merge lp:~jml/lp-dev-utils/public-ip into lp:lp-dev-utils has been updated.

Description changed to:

When using the 'ec2' tool behind a transparent proxy, such as is running at Canonical's Millbank offices, it will fail with an odd error: 

  SSHException: Error reading SSH protocol banner

See http://pastebin.ubuntu.com/960374/ for the full version.

This is because Amazon's checkip service is honouring the X-Forwarded-For HTTP header. Since the IP being forwarded for is internal, checkip returns the internal IP, and then ec2test grants that internal IP ssh access, which means we don't get SSH access and so can't complete setting up the instance.

This branch solves the problem in two ways:
 1. Use whatismyip.akamai.com instead of checkip.amazonaws.com, which behaves properly
 2. Allow users to specify a --public-ip option to override that behaviour

Particular thanks to cjwatson who diagnosed this bug and told me how to fix it.

For more details, see:
https://code.launchpad.net/~jml/lp-dev-utils/public-ip/+merge/104273
-- 
https://code.launchpad.net/~jml/lp-dev-utils/public-ip/+merge/104273
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jml/lp-dev-utils/public-ip into lp:lp-dev-utils.