launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/bug-987898 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #987898 in Launchpad itself: "bugzilla-xmlrpc-transport.txt intermittent test failure"
  https://bugs.launchpad.net/launchpad/+bug/987898

For more details, see:
https://code.launchpad.net/~bac/launchpad/bug-987898/+merge/104399

= Summary =

Test isolation error causes failure when tests are run out of order
and sample data is changed. 

Normally the following tests are run in this order:
lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt
lib/lp/bugs/tests/bugzilla-api-xmlrpc-transport.txt

However, due to shuffling in the parallel test environment they may be
run in the opposite order which exposes an error.

bugzilla-api-xmlrpc-transport.txt modifies the sample data for bug 1
which is then queried by bugzilla-xmlrpc-transport.txt.  The expected
results are now modified when the ordering changes.

== Proposed fix ==

To account for the tests being run in either order, the offending data
is wildcarded with ellipsis in the doctest.

== Pre-implementation notes ==

None

== Implementation details ==

As above.

== Tests ==
bin/test -vv --load-list tests.txt

Where tests.txt contains:
lib/lp/bugs/tests/bugzilla-api-xmlrpc-transport.txt
lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt

== Demo and Q/A ==

N/A

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt

./lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt
     451: source exceeds 78 characters.

Will fix the lint.
-- 
https://code.launchpad.net/~bac/launchpad/bug-987898/+merge/104399
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-987898 into lp:launchpad.

=== modified file 'lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt'
--- lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt	2010-11-08 14:16:17 +0000
+++ lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt	2012-05-02 15:15:59 +0000
@@ -141,7 +141,7 @@
     >>> [bug_dict] = return_value['bugs']
     >>> for key in sorted(bug_dict):
     ...     print "%s: %s" % (key, bug_dict[key])
-    alias: 
+    alias:
     assigned_to: test@xxxxxxxxxxxxx
     component: GPPSystems
     creation_time: 2008-06-10 16:19:53
@@ -152,7 +152,7 @@
     priority: P1
     product: Marvin
     resolution: FIXED
-    see_also: []
+    see_also:...
     severity: normal
     status: RESOLVED
     summary: That bloody robot still exists.
@@ -167,7 +167,7 @@
     ...     for key in sorted(bug_dict):
     ...         print "%s: %s" % (key, bug_dict[key])
     ...     print
-    alias: 
+    alias:
     assigned_to: test@xxxxxxxxxxxxx
     component: GPPSystems
     creation_time: 2008-06-10 16:19:53
@@ -178,7 +178,7 @@
     priority: P1
     product: Marvin
     resolution: FIXED
-    see_also: []
+    see_also:...
     severity: normal
     status: RESOLVED
     summary: That bloody robot still exists.
@@ -216,7 +216,7 @@
     last_change_time: 2008-06-11 09:24:29
     priority: P1
     product: HeartOfGold
-    resolution: 
+    resolution:
     see_also: []
     severity: high
     status: NEW
@@ -252,7 +252,7 @@
     last_change_time: 2008-06-11 09:24:29
     priority: P1
     product: HeartOfGold
-    resolution: 
+    resolution:
     see_also: []
     severity: high
     status: NEW
@@ -298,7 +298,7 @@
     last_change_time: 2008-06-11 09:24:29
     priority: P1
     product: HeartOfGold
-    resolution: 
+    resolution:
     see_also: []
     severity: high
     status: NEW