launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

This branch looks good.  The comments really help the reader understand
what's going on.

The only comment I have is that the two slightly different table name
comparisons gave me a little OCD twitch. ;)

from distroseries_translations_copy.py:

    assert to_table.lower() == "POFile".lower(), (

and from test_distroseries_translations_copy.py:

    if table.lower() == 'pofile':

-- 
https://code.launchpad.net/~jtv/launchpad/bug-891929-tolerate-surprise-pofiles/+merge/104755
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.