launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

This branch looks good.  Here are a couple of things I spotted
while reading over it.

I believe that this bit is a syntax error in Python 2.6 as dict
comprehensions were added in 2.7.  (line 132 of the diff, from
scrub_pofiletranslator.py):

    return {poft.personID: poft for poft in pofts}

Converting it to something like this should work (untested):

    return dict((poft.personID, poft) for poft in pofts)


Since you wrap all calls to measure_distance in abs, you could just put
the abs in measure_distance.

-- 
https://code.launchpad.net/~jtv/launchpad/bug-994650-scrub-pofiletranslator/+merge/104866
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.