launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/dsp-timeout into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #999448 in Launchpad itself: "per-package bug lists now time out (OOPS-590b715f28bec743ec26102fd7332d21)"
  https://bugs.launchpad.net/launchpad/+bug/999448

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/dsp-timeout/+merge/105753

William's latest change to switch a lot of queries to using SourcePackagePublishingHistory.sourcepackagename has had an unintended side effect in IDistributionSourcePackage.latest_overall_publication -- it has a useless FROM clause of SourcePackageRelease, which means that Postgres does a SeqScan across the entire table, and the query time jumps from 2ms to 99,000ms.
-- 
https://code.launchpad.net/~stevenk/launchpad/dsp-timeout/+merge/105753
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/dsp-timeout into lp:launchpad.

=== modified file 'lib/lp/registry/model/distributionsourcepackage.py'
--- lib/lp/registry/model/distributionsourcepackage.py	2012-05-14 04:05:06 +0000
+++ lib/lp/registry/model/distributionsourcepackage.py	2012-05-15 03:22:19 +0000
@@ -243,7 +243,6 @@
                           PackagePublishingStatus.PUBLISHED,
                           PackagePublishingStatus.OBSOLETE),
             clauseTables=["SourcePackagePublishingHistory",
-                          "SourcePackageRelease",
                           "DistroSeries"],
             orderBy=["status",
                      SQLConstant(