launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

> Thanks for the big cleanup. Couple of repeats
> 
> - Please link to the build banner.js in the tests. #177

Got it.

> - Please move the maincontent node generation to setup vs teardown

Got it.

> - Do we still need the animation wait time in #353, or a 400ms wait?
 
We need *some* wait time b/c events are sadly far from instananeous; we don't need 400ms by any measure though, I'll fix that.
-- 
https://code.launchpad.net/~jcsackett/launchpad/use-banner-to-cleanup-beta-notifications/+merge/105732
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.