launchpad-reviewers team mailing list archive

[James Tunnicliffe <launchpad@xxxxxxxxxxxxx>]

James Tunnicliffe has proposed merging lp:~dooferlad/launchpad/upcomingwork_show_incomplete_bp into lp:launchpad.

Requested reviews:
  Graham Binns (gmb)
Related bugs:
  Bug #999717 in Launchpad itself: "upcomingwork view blueprints should be initially expanded if incomplete"
  https://bugs.launchpad.net/launchpad/+bug/999717

For more details, see:
https://code.launchpad.net/~dooferlad/launchpad/upcomingwork_show_incomplete_bp/+merge/105846

The upcomingwork view shows blueprints that a team or individual is working on. Currently all blueprint work items start in the collapsed view, but we have had a request to have incomplete blueprints to be initially expanded.

This change adds an alt tag to the percentage complete image as well as a title, so it can be reliably found in the DOM and the information encoded in the alt tag used to find if a blueprint is complete or not. Of course, this has a pleasing side-effect of making the page more accessible.
-- 
https://code.launchpad.net/~dooferlad/launchpad/upcomingwork_show_incomplete_bp/+merge/105846
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/registry/templates/person-upcomingwork.pt'
--- lib/lp/registry/templates/person-upcomingwork.pt	2012-04-05 13:45:31 +0000
+++ lib/lp/registry/templates/person-upcomingwork.pt	2012-05-15 15:40:21 +0000
@@ -19,6 +19,11 @@
               var expander = new Y.lp.app.widgets.expander.Expander(
                   expander_icon, widget_body);
               expander.setUp(true);
+
+              var percent_done = e.one('[title=percentdone]').get('alt');
+              if (percent_done != "100% complete") {
+                  expander.render(true, false);
+              }
             })
           })
         });
@@ -100,10 +105,12 @@
                  style="border: 1px solid gray; width: 60px">
               <img tal:attributes="
                      id string:container_progressbar_${repeat/container/index};
-                     width string:${container/percent_done}%"
+                     width string:${container/percent_done}%;
+                     alt string:${container/percent_done}% complete;"
                    style="display: block"
                    src="/@@/green-bar"
-                   height="10"/>
+                   height="10"
+                   title="percentdone"/>
             </div>
           </td>
         </tr>