← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~gmb/launchpad/bug-999554 into lp:launchpad

 

Review: Approve code*

Graham, your branch looks good, thank you.
I've just spotted a problem: at line 8 of the diff you removed an interface previously exposed through the webservice.
This generate an error during AppServerLayer set up, e.g. running::
   
    bin/test -t lp.bugs.model.tests.test_bugtask.TestWebservice

Approved with that fix. Waiting for rvba approval.
-- 
https://code.launchpad.net/~gmb/launchpad/bug-999554/+merge/105944
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References