launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

I'll focus on the functionality rather than the code itself because I see that jtv already had a serious look at the code…

still:

[0]

src/maasserver/tests/test_js.py is starting to get huge.  May I suggest moving everything that is not YUIUnitTestsRemote and YUIUnitTestsLocal (fixtures, YUIUnitBase) somewhere in maastesting?  Then maybe it would be worth splitting test_js.py into test_js_local.py and test_js_remove.py.

[1]

I'd like a small paragraph in HACKING.txt that would explain briefly how to set this up.
So far, I've done,
- export MAAS_REMOTE_TEST_BROWSERS="ie9"
-  ./bin/maas test src/maasserver/tests/test_js.py -s
IOError: [Errno 2] No such file or directory: u'/home/me/.saucelabs/connect/credentials'



-- 
https://code.launchpad.net/~allenap/maas/try-out-saucelabs/+merge/106217
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/try-out-saucelabs into lp:maas.