← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/inline-picker-underscore-1005324 into lp:launchpad

 

I've sussed it! The space is collapsed when white-space is processed is normalised. This works:

This fails because there is white-space after the open tag and before the close tag that needs normalisation:
    <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe">
    <span class="invisible-link">Tag help</span>
    </a>

This works:
    <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe"><span class="invisible-link">Tag help</span></a>

As does this:
    <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe"
      ><span class="invisible-link">Tag help</span></a>

The anchor you are working with does not conform to Lp style. We know that browsers do not handle white-space normalisation consistently...webkit is closest to the standard because leading and trailing spaces are supposed to be stripped. Yet this phase causes reallocation of space that ignore the padding rule :(
-- 
https://code.launchpad.net/~wallyworld/launchpad/inline-picker-underscore-1005324/+merge/107702
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References