launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/queue-api-accept-reject into lp:launchpad has been updated.

Description changed to:

== Summary ==

This is a small first step towards fixing bug 1006173, to provide an API sufficient to replace scripts/ftpmaster-tools/queue.

Most of the rest of the work gets fairly big and complicated, so I split off this initial branch since it has value in itself and I hope it's simple enough to be relatively uncontentious.

== Proposed fix ==

Export PU.acceptFromQueue and PU.rejectFromQueue.

I also exported PU.id while I was there, since that makes it a bit easier to emulate the "queue accept ID" form.

== LOC Rationale ==

+91.  I think this is valid because this is part of an arc of work (resourced by Ubuntu Engineering) that will culminate in removing lib/lp/soyuz/scripts/queue.py and scripts/ftpmaster-tools/queue for -862; I expect the whole thing to come in comfortably inside that.

== Tests ==

bin/test -vvct test_packageupload -t xx-packageupload.txt

== Demo and Q/A ==

I have a local implementation of a client-side queue tool that could be used to demo this on (I guess, since I need to run the uploader) dogfood, by accepting and rejecting a couple of uploads.  It's fairly easy to do this by hand in lp-shell, though: use DistroSeries.getPackageUploads() to get hold of some PackageUpload objects, and then call .acceptFromQueue() or .rejectFromQueue() on those.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/queue-api-accept-reject/+merge/107894
-- 
https://code.launchpad.net/~cjwatson/launchpad/queue-api-accept-reject/+merge/107894
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.