launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/better-status-colors into lp:launchpad.

Requested reviews:
  Curtis Hovey (sinzui)

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/better-status-colors/+merge/109000

Summary
=======
On the new bugstatus picker, the INVALID and WONTFIX statuses are not clearly
separated from the description text, as they have the same color.

This color--gray--is a pretty good choice for the statuses, but the issue of
separation is important. This branch attempts to resolve the problem with a
lighter gray and some font-weight changes.

Implementation
==============
The font-weight of choiceedit choice-links is changed to bold; as these
*titles*, the use of bold text is not inconsistent.

The color of the INVALID and WONTFIX statuses is changed to light gray; this
is still readable, while maintaining the semantics of gray text and being
separate from the default gray we use in text.

The changes as seen in the bug status choiceedit can be seen here: http://people.canonical.com/~jc/images/bugstatus-color-issue.png

Tests
=====
None.

QA
==
Verify the presentation is right on qastaging.

LoC
===
This is part of the disclosure work.

Lint
====
Our css files don't appear to conform to the rules in our css linter; almost
every line came up as an error, and so the linting is not included. The
changed lines are consistent with the formats in the file.
-- 
https://code.launchpad.net/~jcsackett/launchpad/better-status-colors/+merge/109000
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/css/colours.css'
--- lib/canonical/launchpad/icing/css/colours.css	2012-03-07 20:57:20 +0000
+++ lib/canonical/launchpad/icing/css/colours.css	2012-06-06 17:26:19 +0000
@@ -107,7 +107,7 @@
     }
 .statusINVALID, .statusINVALID a,
 .statusWONTFIX, .statusWONTFIX a {
-    color: gray;
+    color: lightgray;
     }
 .importanceCRITICAL, .importanceCRITICAL a {
     color: red;

=== modified file 'lib/lp/app/javascript/choiceedit/assets/choiceedit-core.css'
--- lib/lp/app/javascript/choiceedit/assets/choiceedit-core.css	2012-05-16 02:09:30 +0000
+++ lib/lp/app/javascript/choiceedit/assets/choiceedit-core.css	2012-06-06 17:26:19 +0000
@@ -47,6 +47,7 @@
 }
 .yui3-ichoicelist-content .choice-link {
   padding: 0;
+  font-weight: bold;
 }
 .yui3-ichoicelist-content .choice-description {
   font-weight: normal;