launchpad-reviewers team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Review: Approve

Cool, thank you.

I asked about whether id_extensions ought to be id_extension, since you only ever provide one, but you gave me a compelling case in which this would be reasonable ("if someone called the factory with multiple paths then there would need to a 1:1 correspondence to id_extensions") so I'm fine with it.
-- 
https://code.launchpad.net/~bac/launchpad/bug-682772/+merge/108983
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.