launchpad-reviewers team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

Jonathan Lange has proposed merging lp:~jml/launchpad/db-distro-level-ppa-privacy into lp:launchpad/db-devel.

Requested reviews:
  Robert Collins (lifeless): db
  Stuart Bishop (stub): db
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jml/launchpad/db-distro-level-ppa-privacy/+merge/109336

Adds a column to Distribution to control who can create private archives (i.e. P3As, private PPAs) for that distribution (currently Ubuntu only).

The plan is to follow this up with patches that:
 * allow certain folk to view and update this value via the API
 * update tests to say "I need to permissions to create private PPAs" rather than "I must be a commercial admin"
 * change PPA creation to consult this value rather than the commercial_admin celebrity
 * (possibly) make this value control whether launchpad.Commercial is granted on a distribution [it's unclear what that permission means]

No restrictions on when this lands, afaik.
-- 
https://code.launchpad.net/~jml/launchpad/db-distro-level-ppa-privacy/+merge/109336
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jml/launchpad/db-distro-level-ppa-privacy into lp:launchpad/db-devel.

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2012-05-23 02:26:26 +0000
+++ database/schema/comments.sql	2012-06-08 12:02:26 +0000
@@ -1128,7 +1128,7 @@
 COMMENT ON COLUMN Distribution.official_rosetta IS 'Whether or not this distribution uses Rosetta for its official translation team and coordination.';
 COMMENT ON COLUMN Distribution.official_malone IS 'Whether or not this distribution uses Malone for an official bug tracker.';
 COMMENT ON COLUMN Distribution.official_answers IS 'Whether or not this product upstream uses Answers officialy.';
-
+COMMENT ON COLUMN Distribution.private_archive_creator IS 'Person or Team who can create private archives for this distribution.';
 COMMENT ON COLUMN Distribution.translation_focus IS 'The DistroSeries that should get the translation effort focus.';
 COMMENT ON COLUMN Distribution.language_pack_admin IS 'The Person or Team that handle language packs for the distro release.';
 COMMENT ON COLUMN Distribution.enable_bug_expiration IS 'Indicates whether automatic bug expiration is enabled.';

=== added file 'database/schema/patch-2209-22-1.sql'
--- database/schema/patch-2209-22-1.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-22-1.sql	2012-06-08 12:02:26 +0000
@@ -0,0 +1,11 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE Distribution
+ADD COLUMN private_archive_creator INTEGER
+    CONSTRAINT distribution__private_archive_creator__fk
+    REFERENCES Person;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 22, 1);