launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ah, also, for this bit, it would be good to use extra_data.information_type to replace the old 'private' 

371        - if (not bool(getFeatureFlag(
372        - 'disclosure.show_information_type_in_ui.enabled')) and
373        - extra_data.private):
374        - if params.information_type == InformationType.PUBLIC:
375        + if extra_data.private:
376        + if params.information_type in PUBLIC_INFORMATION_TYPES:
-- 
https://code.launchpad.net/~stevenk/launchpad/destroy-old-privacy-ui/+merge/112002
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.