← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jcsackett/launchpad/add-maintainer-to-policies into lp:launchpad

 

Review: Approve code

Can you replace
    product = self.factory.makeProduct()
with
   owner = self.factory.makePerson()
   product = getUtility(IProductSet).createProduct(
       owner, 'carrot', 'Carrot', 'Carrot', 'testing',
       licenses=[License.MIT])
so that it is clear we are testing createProduct()?
-- 
https://code.launchpad.net/~jcsackett/launchpad/add-maintainer-to-policies/+merge/112227
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References