launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve

Thanks JC. Looks ok, but couple of questions if you can peek at before submitting.

#50
It looks like the validate method returns true if get_vote isn't null, and never checks the parent class in that case. I would think that if get_vote was true, it'd not return anything yet, but return the parents validate status. It would only return false if the validation failed at this point? Is this setup correct?

#76 
The renderUI method should just be able to go away since it's not doing anything in addition to the parent class's implementation. There's no need to override it just to call the parent.
-- 
https://code.launchpad.net/~jcsackett/launchpad/comment-cleanup/+merge/113116
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.