← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/launchpad/queue-api-privacy into lp:launchpad

 

Review: Approve code

Looks reasonable, although I'd try moving status into launchpad.View, and you might have to make id public again. You'll likely see a bazillion or so test failures either way, with tests trying to touch even public PackageUploads with no interaction.

-- 
https://code.launchpad.net/~cjwatson/launchpad/queue-api-privacy/+merge/113974
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References