launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #09746
Re: [Merge] lp:~cjwatson/launchpad/queue-api-privacy into lp:launchpad
Review: Approve code
The changes look pretty reasonable, although it'd be nice if we could fix BPB/PU permissions around copies.
70 + try:
71 + signing_key = upload.signing_key
72 + except Unauthorized:
73 + # Copied from a private archive, so the sponsor is none of our
74 + # business.
75 + return None
Is this still necessary after the security adapter change?
--
https://code.launchpad.net/~cjwatson/launchpad/queue-api-privacy/+merge/113974
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References