launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/replace-iso-script into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/replace-iso-script/+merge/115074

We're dropping the Cobbler-oriented maas-import-isos script in favour of the pure MAAS-ey goodness of maas-import-pxe-files.  In this branch I change over the documentation to refer to the new script, and I add a cron job to run the new one as well as maas-import-ephemerals.  (It seems we weren't running the latter, which would be a mistake).

There were a few things I did not change: the old script is still run from cron, and you'll still get the old error messages about running it when profiles are missing in Cobbler.  I put cards on the board for those; we can cut those out after Cobbler is really gone.  By that time the old cron script will be failing harmlessly, and the errors will have no code to make them appear.  I verified the approach with Julian, who said “huh what?” so let's call that a pre-imp.

This does bring us to a period where the hacking/install documentation pretends that we're already without Cobbler when really we still need the old script, although cron will right any problems from that eventually.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/replace-iso-script/+merge/115074
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/replace-iso-script into lp:maas.

=== modified file 'HACKING.txt'
--- HACKING.txt	2012-07-09 14:01:13 +0000
+++ HACKING.txt	2012-07-16 07:34:35 +0000
@@ -203,10 +203,11 @@
     $ sudo cp contrib/preseeds/* /var/lib/cobbler/kickstarts/
     $ sudo cp contrib/snippets/* /var/lib/cobbler/snippets/
 
-Now run ``maas-import-isos`` to download Ubuntu precise and create the
-necessary MAAS profiles::
+Now run ``maas-import-pxe-files`` to download current Ubuntu releases for
+installing nodes::
 
-    $ sudo http_proxy=$http_proxy PATH=$PATH:./bin ./scripts/maas-import-isos
+    $ sudo http_proxy=$http_proxy PATH=$PATH:./bin \
+        ./scripts/maas-import-pxe-files
 
 You need the PATH addition because the script will want to run bin/maas.
 The http_proxy variable is only needed if you're downloading through a

=== modified file 'INSTALL.txt'
--- INSTALL.txt	2012-06-27 10:37:56 +0000
+++ INSTALL.txt	2012-07-16 07:34:35 +0000
@@ -90,13 +90,13 @@
 MAAS will check for and download new Ubuntu images once a week.
 However, you'll need to download them manually the first time::
 
-  $ sudo maas-import-isos
+  $ sudo maas-import-pxe-files
 
 If you are using an HTTP proxy, bear in mind that the "sudo" will not
 pass your http_proxy environment variable on to the script.  If that is
 a problem, pass it on explicitly::
 
-  $ sudo http_proxy=$http_proxy maas-import-isos
+  $ sudo http_proxy=$http_proxy maas-import-pxe-files
 
 
 Next steps

=== added file 'etc/cron.d/maas-import-pxe-files'
--- etc/cron.d/maas-import-pxe-files	1970-01-01 00:00:00 +0000
+++ etc/cron.d/maas-import-pxe-files	2012-07-16 07:34:35 +0000
@@ -0,0 +1,7 @@
+# Runs the MAAS image downloads early every Sunday.
+
+# Installation images:
+11 4 * * 0 root	/usr/sbin/maas-import-pxe-files &> /dev/null
+
+# Ephemeral imaages:
+44 4 * * 0 root /usr/sbin/maas-import-ephemerals &> /dev/null

=== added file 'man/maas-import-pxe-files.8'
--- man/maas-import-pxe-files.8	1970-01-01 00:00:00 +0000
+++ man/maas-import-pxe-files.8	2012-07-16 07:34:35 +0000
@@ -0,0 +1,51 @@
+.TH maas\-import\-pxe-files 8 "16 July 2012" maas "maas"
+.SH NAME
+\fBmaas\-import\-pxe-files\fP \- import Ubuntu install images into cobbler
+
+.SH DESCRIPTION
+\fBmaas\-import\-pxe\-files\fP downloads Ubuntu images and installs them into
+MAAS.  The MAAS server needs these images to provides nodes with operating
+systems.  Images that are already in place are kept unchanged, unless the
+version in the archive has since been updated.
+
+The script reads a configuration file \fI/etc/maas/import_isos\fP in order
+to determine:
+ - ARCHIVE: Location of the Ubuntu download archive
+ - RELEASES: Ubuntu releases to download
+ - CURRENT_RELEASE: Most up-to-date Ubuntu release
+ - ARCHES: Architectures to download images for
+
+The script uses \fBwget\fP(1) to download the kernel and initrd image for
+each architecture in ARCHES and each release in RELEASES.  It will also
+download the current pre-boot loader for each architecture in ARCHES that
+uses this loader.  It always uses the loader from CURRENT_RELEASE.
+
+These images are the minimum that's required to start installng a node.
+During installation, a node will download its packages over the network.
+
+A \fBcron\fP(8) job typically runs this script at a quiet time every Sunday,
+but you may need to run it manually once for a new MAAS installation.
+
+.SH FILES
+\fI/etc/maas/import_isos\fP, \fI/etc/cron.d/maas\-import\-pxe\-files\fP
+
+.SH "SEE ALSO"
+.BR maas\-import\-ephemerals (8),
+.BR maas\-import\-isos (8),
+.BR cron (8), 
+.BR wget (1)
+
+.TP
+\fIhttp://launchpad.net/maas\fP
+.PD
+
+.SH AUTHOR
+This manpage and the script were written by Jeroen Vermeulen
+<jeroen.vermeulen@xxxxxxxxxxxxx> for Ubuntu systems, but may be used by
+others.  Permission is granted to copy, distribute and/or modify this
+document and the utility under the terms of the GNU General Public
+License, Version 3 published by the Free Software Foundation.
+
+The complete text of the GNU General Public License can be found in
+\fI/usr/share/common-licenses/GPL\fP on Debian/Ubuntu systems, or on
+the web at \fIhttp://www.gnu.org/licenses/gpl.txt\fP.