launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Review: Approve

Looks good.

[0]

101	-                '<a class="previous" href="http://example.org/";>PreVious</span>' +
102	-                '<div id="client-listing"></div>' +
103	+                    '<a class="previous" href="http://example.org/";>PreVious</a>' +
104	+                    '<div id="client-listing"></div>' +

I've spotted the fix (s/span/a/) but the indentation seems off.

[1]

119	-        Y.lp.app.listing_navigator.linkify_navigation('#sharee-table-listing');
120	+        Y.lp.app.listing_navigator.linkify_navigation(target);

You explained to me on IRC why this doesn't require a test code change so FTR: 

│18:39:46     rick_h_ | rvba: no, the sharee test code didn't test the navigation html at all relying on the underlying code to test/do it
│18:40:26     rick_h_ | rvba: thought about adding a test, but wasn't sure if it was worth the LoC to test what's tested already.

-- 
https://code.launchpad.net/~rharding/launchpad/reportbug/+merge/115562
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.