launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

There is quite a bit in common between these functions in
lib/lp/soyuz/scripts/tests/test_copypackage.py

- test_checkCopy_forbids_conflicting_files_in_PPAs
- test_checkCopy_allows_source_with_same_filenames
- test_checkCopy_allows_expired_sources_in_destination

It is all preexisting, but perhaps some of that could be moved into a
helper function without obscuring the tests much.

Otherwise the branch looks good.

-- 
https://code.launchpad.net/~cjwatson/launchpad/reorg-copy-package-tests-1/+merge/116321
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.