launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

This looks good.

To see the "true" diff I applied this to client.js and then diffed the
original against the patched with the -w (ignore all white space) flag.
That resulted in this:

--- original	2012-07-23 16:46:17.294237435 -0400
+++ patched	2012-07-23 16:46:10.942120030 -0400
@@ -1068,6 +1068,7 @@
  *
  * @module lp.client.plugins
  */
+    var module = Y.namespace('lp.client.plugins');
 
 /**
  * This plugin overrides the widget _saveData method to update the
@@ -1276,8 +1277,8 @@
     }
 });
 
-Y.namespace('lp.client.plugins');
-Y.lp.client.plugins.PATCHPlugin = PATCHPlugin;
+    module.PATCHPlugin = PATCHPlugin;
 
-  }, "0.1", {"requires": [
-                  "plugin", "dump", "lazr.editor", "lp.client"]});
+}, "0.1", {
+    requires: ["plugin", "dump", "lazr.editor", "lp.client"]
+});

...which reveals the small, non-whitespace changes you described in the
merge proposal comment.

-- 
https://code.launchpad.net/~rharding/launchpad/tab_client/+merge/116329
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.