launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Needs Information code + ui

Hi Ian.

The code looks fine, but I have some concerns about the layout and messages. I think we want to decide what we want to do about these issues, and decide which branch we want to address them

1. The buttons in the screenshot are centred. No design guidelines for any os/web site I have seen suggest centred is correct. Maybe the centreing is an illusion created by the very large content of the bug listing extending beyond the width of the other elements. Lp's rules state the forms action buttons are to bottom left. lazr would place them at the bottom right. We don't have many example align right with real button -- The create milestone overlay is the only one I recall.

2. More bother. The Lp's overlays prefer to make the data the action. So in the screenshot, The cancel action would be the cancel button in the upper right corner, The search field would always be visible so search again is not needed. Plus, taking the search away implies a two step picker and the green progress bar says there is only one step. So instead of Save Duplicate, the user would choose the bug in the listing...but this is not a list. We don't want a listing either. The link to the found bug will reload my page and I loose state. Like the person picker if we need a link we need to be clear that the user can "view details" with a icon telling the user that the link opens a new window.

3. I do not think the privacy warning will deter people from being rude. Maybe
   Marking this bug a duplicate of a private bug prevents contributors from helping,
   and encourages the reporting of more duplicate bugs.
   Is there a public version of this bug that can be used instead?

4. Is it really an error to mark a bug a duplicate of a bug that is already the duplicate? I think this is a no-op where the overlay just closes with a success. 
-- 
https://code.launchpad.net/~wallyworld/launchpad/private-dupe-bug-warning3/+merge/116997
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.