launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

> Hi Ian.
> 
> The code looks fine, but I have some concerns about the layout and messages. I
> think we want to decide what we want to do about these issues, and decide
> which branch we want to address them
> 
> 1. The buttons in the screenshot are centred. No design guidelines for any
> os/web site I have seen suggest centred is correct. Maybe the centreing is an
> illusion created by the very large content of the bug listing extending beyond
> the width of the other elements. Lp's rules state the forms action buttons are
> to bottom left. lazr would place them at the bottom right. We don't have many
> example align right with real button -- The create milestone overlay is the
> only one I recall.
>

I struggled to make this look nice due to the width of the overlay and the small width of the initial lp form to enter the bug number, as laid out by the formoverlay module and the standard lp form html. The initial Save Duplicate and Cancel buttons appeared centred but were in fact laid out to the right edge of the form I think. But since the form itself was narrow and centred, it gave that illusion. Then when the bug details are rendered after the search, the buttons, if right aligned, you have jumped far right and it looked bad. I could find a way to align everything left but the same problem would remain - the 2 "forms" have different widths. And when the overlay expands left and right to accommodate the wider bug details, the buttons would jump left also. Maybe it doesn;t matter.
 
> 2. More bother. The Lp's overlays prefer to make the data the action. So in
> the screenshot, The cancel action would be the cancel button in the upper
> right corner, The search field would always be visible so search again is not
> needed. Plus, taking the search away implies a two step picker and the green
> progress bar says there is only one step. So instead of Save Duplicate, the
> user would choose the bug in the listing...but this is not a list. We don't
> want a listing either. The link to the found bug will reload my page and I
> loose state. Like the person picker if we need a link we need to be clear that
> the user can "view details" with a icon telling the user that the link opens a
> new window.
> 

The current formoverlay usage used in most places is to add the 2 buttons (tick/cross, yes/no, save/cancel etc). But I can look at removing the "cancel" button and rely on the cancel in the top right corner or click outside the form to close it.
I can look at making the search form always visible. 
I can add the details icon as per the picker.

> 3. I do not think the privacy warning will deter people from being rude. Maybe
>    Marking this bug a duplicate of a private bug prevents contributors from
> helping,
>    and encourages the reporting of more duplicate bugs.
>    Is there a public version of this bug that can be used instead?
> 

Thanks, I didn't like my wording.

> 4. Is it really an error to mark a bug a duplicate of a bug that is already
> the duplicate? I think this is a no-op where the overlay just closes with a
> success.

I believe (from memory) that the server call, if made, will result in an error hence I short circuited it.
-- 
https://code.launchpad.net/~wallyworld/launchpad/private-dupe-bug-warning3/+merge/116997
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.