launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

=== modified file 'etc/celeryconfig.py'
...
+# ISC dhcpd configuration file.
+DHCP_CONFIG_FILE = '/etc/dhcp/dhcpd.conf'

I strongly think we need to avoid adding non-Celery config in celeryconfig.py. Instead, you could add a stanza in etc/pserv.yaml, and define its config in provisioningserver.config. I can help if this is going to slow you down disproportionately.

A couple of weeks ago, a config variable in celeryconfig.py was suspected causing weird sporadic start-up failures, which we never fully understood, but removing the config from celeryconfig stopped the failures.

Fwiw, Python configuration files are okay, not great. However, I *hate* it when libs and frameworks demand importable modules, like those defined via CELERY_CONFIG_MODULE or DJANGO_SETTINGS_MODULE and the like. Why didn't they just use a filename?!

-- 
https://code.launchpad.net/~rvb/maas/write-dhcp-server-config/+merge/117660
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/write-dhcp-server-config into lp:maas.