← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~stevenk/launchpad/drop-disclosure-feature-flags into lp:launchpad

 

Review: Approve code

69	@property
70	def enhanced_picker(self):
71	- flag = getFeatureFlag(
72	- "disclosure.add-team-person-picker.enabled")
73	- return flag and self.show_create_team_link
74	+ return self.show_create_team_link

Can you get rid of enhanced_picker entirely?

I'd also like to see a deeper investigation/explanation of the bugsubscription.txt changes.
-- 
https://code.launchpad.net/~stevenk/launchpad/drop-disclosure-feature-flags/+merge/121523
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References