launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

16	+ @enabled_with_permission('launchpad.Edit')
17	+ def visibility(self):
18	+ """Return the 'Set information type' Link."""
19	+ text = 'Change information type'
20	+ return Link('+edit-information-type', text)

Should this be information_type instead of visibility?

55	InformationType.PUBLICSECURITY,
56	InformationType.PRIVATESECURITY,
57	)

Could you fix these to be in the traditional order (between PUBLIC and USERDATA)?

129	+ class="lp.code.browser.branch.BranchEditInformationTypeView"
130	+ permission="launchpad.Edit"

This should probably be launchpad.Moderate. Curtis added it last week to let project owners change the information type too.
-- 
https://code.launchpad.net/~wallyworld/launchpad/branch-infotype-portlet-1040999/+merge/121404
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.