launchpad-reviewers team mailing list archive

[Robie Basak <robie.basak@xxxxxxxxxxxxx>]

Robie Basak has proposed merging lp:~racb/maas/no_install_recommends into lp:maas.

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~racb/maas/no_install_recommends/+merge/122246

Install only hard dependencies rather than all the recommended package
that we don't really need when we do a "make install-dependencies". This
should speed up end-to-end testing of the in-trunk test suite.

I had to add build-essential to required-packages/dev. I presume this
is the right place to put it, because "make install-dependencies" is
only expected to be used by devs?
-- 
https://code.launchpad.net/~racb/maas/no_install_recommends/+merge/122246
Your team MAAS Maintainers is requested to review the proposed merge of lp:~racb/maas/no_install_recommends into lp:maas.

=== modified file 'Makefile'
--- Makefile	2012-08-14 11:58:57 +0000
+++ Makefile	2012-08-31 11:35:59 +0000
@@ -37,7 +37,8 @@
 # Install all packages required for MAAS development & operation on
 # the system. This may prompt for a password.
 install-dependencies:
-	sudo DEBIAN_FRONTEND=noninteractive apt-get -y install \
+	sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
+		--no-install-recommends install \
 		$(shell sort -u required-packages/*)
 
 bin/python bin/pip:

=== modified file 'required-packages/dev'
--- required-packages/dev	2012-07-30 15:52:46 +0000
+++ required-packages/dev	2012-08-31 11:35:59 +0000
@@ -1,3 +1,4 @@
+build-essential
 avahi-utils
 curl
 firefox