launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/launchpad/spec-creation-js into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1052661 in Launchpad itself: "Blueprint creation should use the same information_type widget as editing."
  https://bugs.launchpad.net/launchpad/+bug/1052661

For more details, see:
https://code.launchpad.net/~abentley/launchpad/spec-creation-js/+merge/125038

= Summary =
Selecting information_type during Specification creation uses the pretty widget.

== Pre-implementation notes ==
None

== LOC Rationale ==
Part of Private Projects

== Implementation details ==
In order to use addPopupChoiceForRadioButtons, the list of information_types must be available.  This required each NewSpecification view to provide self.info_types, which duplicated info_type_field logic.  Also, schema had a lot of duplicate logic.  So it was folded into self.append_info_type_field.

In order to invoke lp.blueprints.addspec.dom_ready(), generic-edit.pt had to be replaced with addspec.pt.  (We should look at generalizing this later, perhaps.)

== Tests ==
bin/test test_specification
xvfb-run bin/test --layer=YUITestLayer

== Demo and Q/A ==
Go to all the specification creation screens.  On Product and ProductSeries, if multiple values are permitted, the widget should be shown, listing only the values permitted by the policy.  On Distro and DistroSeries, the widget should not shown.  From the home page and the meeting page, PUBLIC, PROPRIETARY and EMBARGOED should be shown.

On submit, the value selected from the picker should be honoured.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/blueprints/javascript/tests/test_addspec.js
  lib/lp/app/javascript/choice.js
  lib/lp/blueprints/javascript/tests/test_addspec.html
  lib/lp/blueprints/javascript/addspec.js
  lib/lp/blueprints/templates/addspec.pt
  lib/lp/blueprints/browser/configure.zcml
  lib/lp/blueprints/browser/specification.py
  lib/lp/blueprints/browser/tests/test_specification.py
-- 
https://code.launchpad.net/~abentley/launchpad/spec-creation-js/+merge/125038
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/spec-creation-js into lp:launchpad.